[UGENE-6558] Do not pass the workflow validation if it contains non-valid custom external tools Created: 27/Aug/19  Updated: 20/Jun/21  Resolved: 20/Jun/21

Status: Closed
Project: UGENE
Component/s: Workflow
Affects Version/s: master
Fix Version/s: 33

Type: Improvement Priority: Blocker
Reporter: Olga Golosova Assignee: Kirill Rasputin
Resolution: Won't Fix  
Labels: usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to UGENE-6563 Wrong initialization of an element wi... Closed
Assigned Tester: Evelina
Epic Link: Improve CMD elements
Sprint: DEV-33-RELEASE
Affect Type: Userdefined

 Description   

If there is an element with external tool in a workflow, and the corresponding custom external tool hadn't passed validation, do not allow to run the workflow. Show the following error in the errors list instead:

Custom tool "tool_name", specified for the "element_name" element, did't pass validation.


 Comments   
Comment by Evelina [ 11/Jun/21 ]

Scenario (partly described in "scenarios/Regression scenarios/6558/test_0001.txt")

  1. Preferences...->External Tools.
  2. Expand "Custom tools", click Import, open "_common_data/workflow/custom tools configs/my_custom_tool.xml".
  3. Click OK.
  4. "Run or Create Workflow".
  5. On the toolbar, click "Create element with external tool".
  6. In "Configure Element with External Tool" dialog, select "Integrated external tool". "My custom tool" should already be selected in the ET combo box.
  7. Enter "no-run" in the "Element name" field.
  8. Click Next a few times, then Finish.
    Expected: "no-run" element has been added to the scene.
  9. "Run workflow". The "Workflow cannot be executed" message box appears.
    Expected: "Error list" contains the message "Custom tool "My custom tool", specified for the "no-run" element, didn't pass validation."
    Current: the "Error list" contains "no-run: External tool "My custom tool" is not set. You can set it in Settings -> Preferences -> External Tools".

I expect to see the message that was in the commit for this issue, which is described in the issue scenario (scenarios/Regression scenarios/6558/test_0001.txt).

 

Where is the GUI or/and xml test?

Generated at Fri Mar 29 19:52:07 NOVT 2024 using Jira 8.5.0#805000-sha1:facbf8be6a56ed8ab71dea158b6e159962506101.