Uploaded image for project: 'UGENE'
  1. UGENE
  2. UGENE-1261

Validation of annotation controller: separation of concerns is disturbed

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.11.4, 1.12
    • Component/s: None
    • Labels:
      None

      Description

      As we know from crash reports, a lot of unreproducible crashes occur near the "CreateAnnotationWidgetController" class.
      We have found that its "validate" method not only validates the model but updates this model!

      Addition of a simple feature UGENE-1255 leaded to a new crash after validating the model.

      It is needed to remove updateModel call from the validate method.
      Also, remove the temporary stub from the updateModel method:

      if (model.annotationObjectRef.isValid()) { // TODO: remove this and updateModel call from validate
          return;
      }
      

        Attachments

          Activity

            People

            Assignee:
            vaskin Yura Vaskin
            Reporter:
            ggrekhov German Grekhov
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: