Uploaded image for project: 'UGENE'
  1. UGENE
  2. UGENE-2196

src/muscle/muscle_context.cpp:558: bad call to memset

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.12.3, 1.13
    • Component/s: None
    • Environment:

      Linux

    • Tests Type:
      Untestable
    • Sprint:
      DEV-2013/10/03
    • Affect Type:
      Userdefined

      Description

      I just ran the static analysis checker "cppcheck" over the source
      code of ugene-1.12.2

      It said many things, including

      1.

      [src/muscle/muscle_context.cpp:558]: (warning) memset() called to fill 0 bytes of 'str'.

      Source code is

      memset(str, 4096, '\0');

      I think

      memset(str, '\0', 4096);

      might be better.

        Attachments

          Activity

            People

            Assignee:
            atiunov Aleksey Tiunov
            Reporter:
            dcb David Binderman
            Assigned Tester:
            Eugenia Pushkova [X] (Inactive)
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 1 hour
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified