Uploaded image for project: 'UGENE'
  1. UGENE
  2. UGENE-4824

Unsafe code in MDIManagerImpl.cpp

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.19
    • Component/s: None
    • Labels:
      None
    • Story Points:
      1
    • Tests Type:
      Untestable
    • Sprint:
      DEV-10/11/2015
    • Affect Type:
      Technical

      Description

      Сurrently crashes may occur in MDIManagerImpl.cpp due to lack of checking of pointers for nulls. Refactor the code, add additional checks and replace assert() with SAFE_POINT().
      For exampale in 399 line there is those code: "mdiContentOwner->w->setupMDIToolbar(tb);", but mdiContentOwner and w are not checked for nulls.
      Crash report:
      http://ugene.net/ugenecrashes?id=6821

        Attachments

          Activity

            People

            Assignee:
            artyom_s Artyom Savchenko
            Reporter:
            artyom_s Artyom Savchenko
            Assigned Tester:
            Kirill Rasputin
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: