Uploaded image for project: 'UGENE'
  1. UGENE
  2. UGENE-4932

Unsafe code in RunCmdlineWorkflowTask

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.20
    • Component/s: None
    • Labels:
      None
    • Story Points:
      1
    • Tests Type:
      Untestable
    • Sprint:
      DEV-02/12/2015
    • Affect Type:
      Userdefined

      Description

      There is the following code in 579 line in WorkflowRunTask.cpp:

      proc->start(cmdlineUgenePath, args);
      #if (defined(Q_OS_WIN32) || defined(Q_OS_WINCE))
      processLogPrefix = QString("process:%1>").arg(proc->pid()->dwProcessId);
      #else
      processLogPrefix = QString("process:%1>").arg(proc->pid());
      #endif

      Replace "pid()" function with "processId()" in accordance with the recommendations in Qt and and verify that the process is successfully launched(processId() != NULL).

      Crash report:
      http://ugene.net/ugenecrashes?id=6908

        Attachments

          Activity

            People

            Assignee:
            artyom_s Artyom Savchenko
            Reporter:
            artyom_s Artyom Savchenko
            Assigned Tester:
            Aleksey Tiunov
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: