Uploaded image for project: 'UGENE'
  1. UGENE
  2. UGENE-978

Check the overlapped results for "Search in Sequence"

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.10.4
    • Fix Version/s: 1.11.2
    • Component/s: Basic-Nucl, Basic-Protein
    • Labels:
      None
    • Affect Type:
      Userdefined

      Description

      When "Find pattern" dialog was moved to the Options Panel (see UGENE-392), the following statement in the old source code was ignored: "TODO: the statement below is always false".

                  U2Region r = rj->res.region.intersect(ri->res.region);
                  if (r.length > 0 && r.length >= MAX_OVERLAP_K * ri->res.region.length) {
                      //TODO: the statement below is always false
                      if (ri->res.err > ri->res.err) {
                          delete ri;
                          i--;
                          break;
                      } else {
                          j--;
                          delete rj;
                      }
                      n--;
                  } else {
                      break;
                  }
      

      A set of tests should be written to verify that overlapped results work as expected.

        Attachments

          Activity

            People

            Assignee:
            kir Kirill Rasputin
            Reporter:
            oigl Olga Golosova
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: